On Wed, Apr 11, 2012 at 04:42:13PM -0700, Eric Anholt wrote: > On Wed, 11 Apr 2012 22:12:45 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote: > > Hi all, > > > > This patch series is inspired by Ben's ring->get|put_irq cleanup for gen6+ and > > my perpetual hatred for intel_ringbuffer.c. > > > > It's a lot of churn, but the end result is imho worth it - I almost started to > > like what the ringbuffer abstraction looks like now. There are some follow-up > > cleanups possible, but I think that can wait until we've cleanup up our domain > > tracking and ripped out the flushing_list (if that ever happens). > > > > Commments, flames and review highly welcome. > > This is so nice. It's way better than the series I started with when > working on domain tracking lobotomy. tbh it's far from my first attempt at this, and I've dodged the domain tracking things mostly by leaving the ring->flush code as-is. > Except for a s/bds/bsd/ in patch 4's commit message, Fixed, same for the s/ring->flush/ring->add_request/ noticed by Ben. > Reviewed-by: Eric Anholt <eric at anholt.net> Thanks for the review, all queued for -next. Imo Ben's concerns are valid, but better tackled in follow up patches. -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
