On Fri, Dec 22, 2017 at 08:51:41AM +0000, Zhenyu Wang wrote: > On 2017.12.22 09:49:36 +0200, Jani Nikula wrote: > > > > Yes. We want a minimum of two people looking at each patch. It's pretty > > much irrelevant if the committer/maintainer is the author or not. 2*sob > > or sob+rb or sob+ack, or more for more complicated things. > > > > It's unfortunately common that the "obviously correct and trivial" patch > > quickly committed by the author without anyone else looking at it is > > actually buggy... > > > > > If yes, I will apply this rule for gvt tree as well and encourage gvt > > > developer to send a-b/r-b mail as looks people more like to use IM to > > > exchange review comment.. > > > > We don't have a strict rule to always send acks or rb by mail. IRC or IM > > is fine too for simple things. But we want to record the acks and rb in > > the commit regardless. When I push patches that got IRC review, I add > > the tags, and typically reply with something along the lines of, "Pushed > > with J. Random Hacker's IRC review". > > > > That said, I do encourage explicit ack/rb messages on the lists for > > non-trivial things in the interest of open development and transparency. > > > > Thanks to clarify! Here's updated pull for commits that were verified and > acked by Xiong and Zhi, now with proper r-b tag. Thanks a lot for the quick action on this. Pulled to dinq. > > thanks > -- > The following changes since commit ee5b5bf351ec8cd8f11c631cb76b30f602e866ee: > > drm/i915: Update DRIVER_DATE to 20171214 (2017-12-14 12:10:02 -0800) > > are available in the Git repository at: > > https://github.com/intel/gvt-linux.git tags/gvt-next-2017-12-22 > > for you to fetch changes up to 4fafba2d73fcaf1b433c26e753a98ad4b231754a: > > drm/i915/gvt: move write protect handler out of mmio emulation function (2017-12-22 16:33:50 +0800) > > ---------------------------------------------------------------- > gvt-next-2017-12-22: > > - more mmio switch optimization (Weinan) > - cleanup i915_reg_t vs. offset usage (Zhenyu) > - move write protect handler out of mmio handler (Zhenyu) > > ---------------------------------------------------------------- > Weinan Li (4): > drm/i915/gvt: refine trace_render_mmio > drm/i915/gvt: optimize for vGPU mmio switch > drm/i915/gvt: refine mocs save restore policy > drm/i915/gvt: load host render mocs once in mocs switch > > Xiaolin Zhang (1): > drm/i915/gvt: Fix pipe A enable as default for vgpu > > Zhenyu Wang (4): > Merge tag 'drm-intel-next-2017-12-14' into gvt-next > drm/i915/gvt: always use i915_reg_t for MMIO handler definition > drm/i915/gvt: cleanup usage for typed mmio reg vs. offset > drm/i915/gvt: move write protect handler out of mmio emulation function > > drivers/gpu/drm/i915/gvt/cmd_parser.c | 39 +- > drivers/gpu/drm/i915/gvt/display.c | 81 ++-- > drivers/gpu/drm/i915/gvt/edid.c | 22 +- > drivers/gpu/drm/i915/gvt/fb_decoder.c | 30 +- > drivers/gpu/drm/i915/gvt/gtt.c | 37 +- > drivers/gpu/drm/i915/gvt/gtt.h | 3 + > drivers/gpu/drm/i915/gvt/gvt.c | 1 + > drivers/gpu/drm/i915/gvt/gvt.h | 33 +- > drivers/gpu/drm/i915/gvt/handlers.c | 750 ++++++++++++++++---------------- > drivers/gpu/drm/i915/gvt/kvmgt.c | 4 +- > drivers/gpu/drm/i915/gvt/mmio.c | 57 +-- > drivers/gpu/drm/i915/gvt/mmio.h | 7 - > drivers/gpu/drm/i915/gvt/mmio_context.c | 238 +++++----- > drivers/gpu/drm/i915/gvt/trace.h | 15 +- > drivers/gpu/drm/i915/gvt/vgpu.c | 24 +- > 15 files changed, 675 insertions(+), 666 deletions(-) > > > -- > Open Source Technology Center, Intel ltd. > > $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx