On Wed, 11 Apr 2012 11:18:20 -0700, Ben Widawsky <ben at bwidawsk.net> wrote: > This fixes a long standing issue where emitting the semaphore updates > may have failed, but we've already updated our internal data structure. > > Reported-by: Daniel Vetter <daniel.vetter at ffwll.ch> > Signed-off-by: Ben Widawsky <benjamin.widawsky at intel.com> I would have written it as ret == 0, but since I didn't write this, Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> Fortunately the impact of the bug would have been render corruption and not a GPU hang. -Chris -- Chris Wilson, Intel Open Source Technology Centre