On Tue, 10 Apr 2012 23:50:45 +0200 Daniel Vetter <daniel at ffwll.ch> wrote: > On Tue, Apr 10, 2012 at 11:58:05AM -0700, Jesse Barnes wrote: > > On IVB, there are two sets of panel backlight regs: one in the CPU and > > one in the PCH. The CPU ones aren't generally used, so on IVB make sure > > we allow the PCH regs to actually control the backlight. > > > > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org> > > --- > > drivers/gpu/drm/i915/intel_panel.c | 12 ++++++++++++ > > 1 files changed, 12 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c > > index cad45ff..b007c4e 100644 > > --- a/drivers/gpu/drm/i915/intel_panel.c > > +++ b/drivers/gpu/drm/i915/intel_panel.c > > @@ -306,6 +306,18 @@ static void intel_panel_init_backlight(struct drm_device *dev) > > { > > struct drm_i915_private *dev_priv = dev->dev_private; > > > > + /* > > + * IVB has CPU eDP backlight regs too, set things up to let the > > + * PCH regs control the backlight > > + */ > > + if (IS_IVYBRIDGE(dev)) { > > + u32 pwm; > > That pwm thing seems unused ... > -Daniel Oh yeah we can drop that now. -- Jesse Barnes, Intel Open Source Technology Center -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120410/43cdcaed/attachment.pgp>