On Tue, 10 Apr 2012 11:58:04 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote: > If these regs don't have valid values, the panel won't come up, and may > even cause a system hang. So do a basic sanity check when an eDP panel > is detected. > > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org> Other than adding a cleanup: error path (definitely before the third person cut'n'pastes the intel_dp*destroy()), and that checking for zero seems a little crude, Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> -Chris -- Chris Wilson, Intel Open Source Technology Centre