On Mon, Apr 09, 2012 at 03:48:03PM +0000, Reese, Armin C wrote: > Thanks for the review, Ben. > > Yes, I was a bit paranoid about what values could be in gtt_offset. But > if it's always a multiple of 0x1000, we can save an additional mask > operation. I'll make the change and resubmit. And a small style nitpick: Please prepend "drm/i915: " to your patch headline when resending. -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48