On Thu, Apr 05, 2012 at 01:55:12PM +0200, Daniel Vetter wrote: > On Thu, Apr 5, 2012 at 13:04, Konstantin Belousov <kostikbel at gmail.com> wrote: > > it seems that the loop in i915_gem_init_aliasing_ppgtt() over pd_entries > > that calculates pt_addr does nothing after the commit 55a254ac in the > > !dmar case. Would it be better to move needs_dmar check over the whole > > loop ? > > For the !dmar case we still need need to compute the physical address > with page_to_phys, so I think the loop is needed. Does linux' page_to_phys() has side effects ? I just fail to see where the pt_addr is used after the calculation. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 196 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120405/9df1ccc3/attachment.pgp>
