[PATCH] drm/i915: fixup seqno allocation logic for lazy_request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 25, 2012 at 03:46:51PM +0000, Chris Wilson wrote:
> The actual refactoring patch are also ok, though I'd like for Daniel
> to scope out who owns the seqno vs the request, especially in the light
> of no-more-domains...

I've thought a bit more about this and one great upside of seqnos over a
simple pointer to the request is that we'd need to properly manage
references to the latter. I.e. when we free a request we would need to
ensure that anyone still referencing it is actually gone, and the current
code is unfortunately quite far away from that :(

I think we should keep this refactor idea in mind and look at it again
after no-more-domains and after intel_ringbuffer.c has been simplified.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux