On Fri, Nov 04, 2011 at 05:03:54PM -0700, Ben Widawsky wrote: > The GTFIFODBG register gives us 3 error types when the fifo is accessed > and full. Whenever we do a forcewake_put we can check this register to > see if any of the CPU related errors occurred. > > Of more interest is perhaps the bit I am not checking which tells when > some other part of the chip makes a request and the FIFO is full. I > couldn't really decide on a good place to put that check. > > This patch seems to have value to me, but I'm not sure it's worth the > cost of the extra MMIO read`. (I've yet to see this occur, but I haven't > actually been running with it for very long). > This looks like a nice little patch here. Care to update it for spinlocked and multithreaded forcewake and maybe also check the other errors? And also add it to the error_state output (just base it on top of danvet/my-next to avoid conflicts with the oustanding error_state cleanup). Thanks, Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
