On Sat, Jan 07, 2012 at 09:39:19PM +0800, Wu Fengguang wrote: > On Fri, Jan 06, 2012 at 07:08:33AM -0800, Jesse Barnes wrote: > > On Fri, 6 Jan 2012 11:26:40 +0800 > > Wu Fengguang <fengguang.wu at intel.com> wrote: > > > > > Andrea, > > > > > > Would you test this patch at convenient time? > > > > > > Thanks, > > > Fengguang > > > > > > --- > > > Subject: drm/i915: add an "off-dvi" HDMI audio mode > > > Date: Fri Jan 06 11:04:00 CST 2012 > > > > > > When HDMI-DVI converter is used, it's not only necessary to turn off > > > audio, but also to disable HDMI_MODE_SELECT and video infoframe. Since > > > the DVI mode is mainly tied to audio functionality from end user POV, > > > add a new "off-dvi" audio mode: > > > > > > xrandr --output HDMI1 --set audio off-dvi > > > > > > Reported-by: Andrea Arcangeli <aarcange at redhat.com> > > > Signed-off-by: Wu Fengguang <fengguang.wu at intel.com> > > > --- > > > > My only complaint here is that off-dvi isn't an intuitive name. We > > don't have any better way of detecting an HDMI->DVI converter with > > other EDID bits perhaps? > > We have > > intel_hdmi->has_hdmi_sink = drm_detect_hdmi_monitor(edid); > > which _should_ auto detect HDMI/DVI connections. > > I guess Andrea ran into problem with that due to broken EDID. Anyway > I'll try to test if that drm_detect_hdmi_monitor() will ever work for > the HDMI/DVI monitors in my lab. I verified that drm_detect_hdmi_monitor() at least works fine for me when HDMI<>DVI converter is used: [ 12.567158] [drm:intel_hdmi_detect], has_hdmi_sink=0 has_audio=0 force_audio=0 So it's probably Andrea's monitor sending the wrong EDID. Thanks, Fengguang
