> -----Original Message----- > From: Adam Jackson [mailto:ajax at redhat.com] > Sent: Tuesday, January 10, 2012 8:34 PM > To: Kavuri, Sateesh > Cc: intel-gfx at lists.freedesktop.org > Subject: Re: [PATCH] Android port of intel-gpu-tools > > On 1/9/12 11:45 PM, Sateesh Kavuri wrote: > > Added support for Android. Changes include fixes for compilation issues > > related to Android using an older version of GCC compiler (ver 4.3.3) > > while the latest version of intel-gpu-tools confirms to GCC ver 4.5.2 > > (C99 standard functions), using functions like getline(). Fixed such > > functions, header dependencies for android and added an Android.mk file. > > I can understand avoiding C99 functions that android doesn't have, but this kind > of thing: > > > + #ifdef ANDROID > > + int i; > > + for (i = 1; i< len; i++) { > > + #else > > for (int i = 1; i< len; i++) { > > + #endif > > is silly. Does gcc -std=c99 on android seriously not cope with this? Yes, -std=c99 would help to get rid of such silly checks (would fix it). Continued this, since there has to be a ANDROID definition for checks like fcntl.h header path > > - ajax -- Sateesh
