On Sat, Nov 19, 2011 at 00:24, Ben Widawsky <ben at bwidawsk.net> wrote: > This code is currently living on my personal git repo: > git://people.freedesktop.org/~bwidawsk/drm-intel<http://people.freedesktop.org/%7Ebwidawsk/drm-intel>forced_throttling > > Since these are RFC, I haven't spent too much time cleaning things up. > Feel free to comment on typos, comments you feel are missing, etc. I > also haven't spent any time running the standard kernel tests, kmemleak > and such - I intend to do so while these are reviewed here. > > There are two main "scheduler" types implemented in this patch. What I > refer to as a fairness scheduler, and a batch scheduler. The fairness > scheduler is currently implemented on batch granularity but that is not > guaranteed going forward. The batch scheduler is a way to set batch > limits per pid. Refer to the relevant patch for more details. > > It is my opinion that the fairness scheduler isn't terribly interesting > except to prevent badly written, or malicious apps. For example, a 3d > app which queues up a ton of work but never calls glxSwapBuffer. > > The batch scheduler is also somewhat uninteresting as the values it uses > require proper tuning and will vary from system to system, and even then > depending on what's currently running. But like the fairness one, this > too has its applications. > > Most comments and feedback are welcome. > I am not that expert about how GPU scheduling works, but all the patches make sense to me and I haven't found anything apparently wrong. I have one feature request for patch 11, which is to list available schedulers via a debugfs entry. For example: # cat /sys/kernel/debug/dri/0/i915_available_schedulers none *fair batch or list them in the output of i915_scheduler, like: # cat /sys/kernel/debug/dri/0/i915_scheduler ... Scheduler: batch Available schedulers: none fair batch To see what schedulers are available for usage. But besides this, for the series: Tested-by: Eugeni Dodonov <eugeni.dodonov at intel.com> Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com> -- Eugeni Dodonov <http://eugeni.dodonov.net/> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20111129/a018931b/attachment-0001.htm>
