On Wed, May 24, 2017 at 04:52:11PM +0200, Daniel Vetter wrote: > It again looks all cargo-culted for no good reasons. drm_vblank_cleanup() is called to release the resources allocated by drm_vblank_init(). I think that's the reason, no? Shawn > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx> > --- > drivers/gpu/drm/zte/zx_drm_drv.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/zte/zx_drm_drv.c b/drivers/gpu/drm/zte/zx_drm_drv.c > index 490aafc99610..696836303229 100644 > --- a/drivers/gpu/drm/zte/zx_drm_drv.c > +++ b/drivers/gpu/drm/zte/zx_drm_drv.c > @@ -149,7 +149,6 @@ static int zx_drm_bind(struct device *dev) > out_poll_fini: > drm_kms_helper_poll_fini(drm); > drm_mode_config_cleanup(drm); > - drm_vblank_cleanup(drm); > out_unbind: > component_unbind_all(dev, drm); > out_unregister: > @@ -171,7 +170,6 @@ static void zx_drm_unbind(struct device *dev) > } > drm_kms_helper_poll_fini(drm); > drm_mode_config_cleanup(drm); > - drm_vblank_cleanup(drm); > component_unbind_all(dev, drm); > dev_set_drvdata(dev, NULL); > drm->dev_private = NULL; > -- > 2.11.0 > _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx