On Sat, Nov 19, 2011 at 16:32, Keith Packard <keithp at keithp.com> wrote: > On Sat, 19 Nov 2011 07:25:09 -0200, Eugeni Dodonov <eugeni at dodonov.net> wrote: > >> Just one question I caught on 2nd read. Shouldn't we have #else within >> this #ifdef block, to return 1? Otherwise, if CONFIG_INTEL_IOMMU is >> not defined, we'll always disable rc6. > > Oops! Thanks for catching this. Here's a new version of that function > (the rest of the patch is the same). This one has explicit conditions > for Ironlake and Sandybridge (when CONFIG_INTEL_IOMMU is set), allowing > the Ivybridge and Sandybridge-without-IOMMU cases to take the default > path. This will also cause all future chips to enable rc6 by default. Great, I think it catches all cases now. Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com> Thanks! -- Eugeni Dodonov
