At Tue, 15 Nov 2011 13:54:44 -0800, Kamal Mostafa wrote: > > On Tue, 2011-11-15 at 21:28 +0100, Takashi Iwai wrote: > > My rough guess is the inconsistency of property taken during the > > backlight disabled. How about the patch below (untested!) in addition > > to the fix in 3.2? > > > > > > Takashi > > Yes Takashi, your patch below (plus the already committed fix[0]) does > indeed fix the problem[1] for me. Thanks! > > Tested-by: Kamal Mostafa <kamal at canonical.com> OK, I'll resend the patch with proper sign-off, etc. thanks, Takashi > > -Kamal > > [0] f52c619a590fa75276c07dfcaf380dee53e4ea4c > drm/i915/panel: Always record the backlight level again (but cleverly) > > [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/872652 > > > > > --- > > diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c > > index 499d4c0..21f60b7 100644 > > --- a/drivers/gpu/drm/i915/intel_panel.c > > +++ b/drivers/gpu/drm/i915/intel_panel.c > > @@ -326,7 +326,8 @@ static int intel_panel_update_status(struct backlight_device *bd) > > static int intel_panel_get_brightness(struct backlight_device *bd) > > { > > struct drm_device *dev = bl_get_data(bd); > > - return intel_panel_get_backlight(dev); > > + struct drm_i915_private *dev_priv = dev->dev_private; > > + return dev_priv->backlight_level; > > } > > > > static const struct backlight_ops intel_panel_bl_ops = { > > >
