On Mon, 14 Nov 2011 18:39:14 -0200 Eugeni Dodonov <eugeni.dodonov at intel.com> wrote: > Semaphores seem to fix most of the hangs on SNB and IVB, and do not cause > any known regressions as of now. > > Let's re-enable them by default to provide a wider testing and coverage. > > Acked-by: Keith Packard <keithp at keithp.com> > CC: Jesse Barnes <jbarnes at virtuousgeek.org> > CC: Daniel Vetter <daniel.vetter at ffwll.ch> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42696 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40564 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41353 > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38862 > Signed-off-by: Eugeni Dodonov <eugeni.dodonov at intel.com> > --- > drivers/gpu/drm/i915/i915_drv.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index cc531bb..71f887a 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -58,10 +58,10 @@ module_param_named(powersave, i915_powersave, int, 0600); > MODULE_PARM_DESC(powersave, > "Enable powersavings, fbc, downclocking, etc. (default: true)"); > > -unsigned int i915_semaphores __read_mostly = 0; > +unsigned int i915_semaphores __read_mostly = 1; > module_param_named(semaphores, i915_semaphores, int, 0600); > MODULE_PARM_DESC(semaphores, > - "Use semaphores for inter-ring sync (default: false)"); > + "Use semaphores for inter-ring sync (default: true)"); > > unsigned int i915_enable_rc6 __read_mostly = 0; > module_param_named(i915_enable_rc6, i915_enable_rc6, int, 0600); I think we should keep them enabled; if one or two fat cats in the 1% still have issues we can debug those without bringing down performance for the other 99%. Acked-by: Jesse Barnes <jbarnes at virtuousgeek.org> -- Jesse Barnes, Intel Open Source Technology Center -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20111114/bf88aef2/attachment.pgp>
