On Mon, 14 Nov 2011 20:09:03 +0800, Zhigang Gong <zhigang.gong at linux.intel.com> wrote: > According to Chris's comments, this commit try to > elminate #ifdef from the body of the code if possible. > We check the flags to determine whether enable GLAMOR > at runtime, rather than check the MACRO during the compile > time. I was thinking more along the lines of pushing the actual check out of I830CloseScreen (and friends) and into the intel_glamor routines. That way the interface to glamor is fairly self-contained and the existing code can be gradually whittled away until it is simply a call into intel_glamor, at which point we can remove the existing layer. Inside uxa, the inline checks are indeed better as this layer should be tightly integrated with the available acceleration methods. -Chris -- Chris Wilson, Intel Open Source Technology Centre
