On Wed, Aug 24, 2016 at 03:33:30PM +0100, John Harrison wrote: > On 22/08/2016 09:03, Chris Wilson wrote: > >As i915.enable_cmd_parser is an unsafe option, make it read-only at > >runtime. Now that it is constant, we can use the value determined during > >initialisation as to whether we need the cmdparser at execbuffer time. > I'm confused. I can't see where i915.enable_cmd_parse is used now. > It does not appear to be mentioned anywhere other than i915_params.c > after this patch. It is not used to calculate > engine->needs_cmd_parser. There also seems to be no longer a check > for PPGTT either. It was meant to be at the start of intel_engine_init_cmd_parser(). https://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=breadcrumbs&id=52265e7a149a1721f31c443ef27de362f74a3309 The joy of rebasing :| -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
