Re: [PATCH v2] drm/i915: don't track relative-constants-mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 26, 2016 at 08:46:25PM +0100, Dave Gordon wrote:
> @@ -1520,6 +1528,14 @@ static void eb_export_fence(struct drm_i915_gem_object *obj,
>  	if (ret)
>  		return ret;
>  
> +	if (instp_mode != I915_EXEC_CONSTANTS_REL_GENERAL) {
> +		/* Restore default value of INSTPM */
> +		ret = emit_instpm(params->request, instp_mask,
> +				  I915_EXEC_CONSTANTS_REL_GENERAL);
> +		if (ret)
> +			return ret;

We can't return an error at this point, we are committed to executing
the batch. And we do expect to see at least an EINTR here occasionally.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux