Re: [PATCH 2/4] drm/i915: Simplify ELSP queue request tracking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 23, 2016 at 05:28:07PM +0300, Mika Kuoppala wrote:
> > +	/* Try to read in pairs and fill both submission ports */
> > +	spin_lock(&engine->execlist_lock);
> > +	list_for_each_entry(cursor, &engine->execlist_queue, execlist_link) {
> > +		if (last && !merge_ctx(cursor->ctx, last->ctx)) {
> > +			if (port != engine->execlist_port)
> > +				break;
> 
> In here you will merge ctx also for the second port?
>
> The previous version of the code was careful to only merge for
> the first port/request.

Careful? Hah.
-Chris
 
-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux