On Tue, Aug 23, 2016 at 03:43:15PM +0200, Daniel Vetter wrote: > On Tue, Aug 23, 2016 at 2:21 PM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > > On Tue, Aug 23, 2016 at 02:05:18PM +0200, Daniel Vetter wrote: > >> On Tue, Aug 23, 2016 at 11:04:03AM +0300, Joonas Lahtinen wrote: > >> > On ti, 2016-08-23 at 08:22 +0100, Chris Wilson wrote: > >> > > PAGE_KERNEL_IO is an x86-ism. Though it is used to define the pgprot_t > >> > > used for the iomapped region, it itself is just PAGE_KERNEL. On all > >> > > other arches, PAGE_KERNEL_IO is undefined so in a general header we must > >> > > refrain from using it. > >> > > > >> > > >> > There is; > >> > > >> > #define __PAGE_KERNEL_IO (__PAGE_KERNEL) > >> > > >> > So no functional change, but will compile on all archs. > >> > > >> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> > >> > >> Still not happy: > >> > >> CC drivers/gpio/gpiolib-of.o > >> In file included from drivers/gpio/gpiolib-of.c:19:0: > >> ./include/linux/io-mapping.h: In function ‘io_mapping_init_wc’: > >> ./include/linux/io-mapping.h:125:16: error: implicit declaration of function ‘pgprot_writecombine’ [-Werror=implicit-function-declaration] > >> iomap->prot = pgprot_writecombine(PAGE_KERNEL); > >> ^~~~~~~~~~~~~~~~~~~ > >> ./include/linux/io-mapping.h:125:36: error: ‘PAGE_KERNEL’ undeclared (first use in this function) > >> iomap->prot = pgprot_writecombine(PAGE_KERNEL); > >> ^~~~~~~~~~~ > > > > That was pulled in by the x86 headers, > > > > #include <asm/pgtable.h> > > Can you pls respin? Was that right? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
