Op 17-08-16 om 21:55 schreef Lyude: > Thanks to Ville for suggesting this as a potential solution to pipe > underruns on Skylake. > > On Skylake all of the registers for configuring planes, including the > registers for configuring their watermarks, are double buffered. New > values written to them won't take effect until said registers are > "armed", which is done by writing to the PLANE_SURF (or in the case of > cursor planes, the CURBASE register) register. > > With this in mind, up until now we've been updating watermarks on skl > like this: This patch breaks on plane disabling. I think that all the disable_plane hooks should zero all the watermark values. This might also make modeset more reliable It's shown in this testcase that I wrote to expose this issue: kms_atomic_transition.plane-all-modeset-transition I've applied patch 1, 2, 3 and 5 with some minor fixes. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
