From: Tom O'Rourke <Tom.O'Rourke@xxxxxxxxx> The SLPC interface has changed and could continue to change. Only GuC versions known to be compatible are supported here. On Skylake, GuC firmware v6 is supported. Other platforms and versions can be added here later. v1: Updated with modified sanitize_slpc_option in earlier patch. Reviewed-by: David Weinehall <david.weinehall@xxxxxxxxxxxxxxx> Signed-off-by: Tom O'Rourke <Tom.O'Rourke@xxxxxxxxx> Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@xxxxxxxxx> --- drivers/gpu/drm/i915/intel_guc_loader.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_guc_loader.c b/drivers/gpu/drm/i915/intel_guc_loader.c index 2dfdb24..023064d 100644 --- a/drivers/gpu/drm/i915/intel_guc_loader.c +++ b/drivers/gpu/drm/i915/intel_guc_loader.c @@ -146,6 +146,8 @@ static void direct_interrupts_to_guc(struct drm_i915_private *dev_priv) static void sanitize_slpc_option(struct drm_i915_private *dev_priv) { + struct intel_guc_fw *guc_fw = &dev_priv->guc.guc_fw; + /* Handle default case */ if (i915.enable_slpc < 0) i915.enable_slpc = HAS_SLPC(dev_priv); @@ -161,6 +163,9 @@ static void sanitize_slpc_option(struct drm_i915_private *dev_priv) /* slpc requires guc submission */ if (!i915.enable_guc_submission) i915.enable_slpc = 0; + + if (IS_SKYLAKE(dev_priv) && (guc_fw->guc_fw_major_found != 6)) + i915.enable_slpc = 0; } static u32 get_gttype(struct drm_i915_private *dev_priv) -- 1.9.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx