On ti, 2016-08-16 at 11:42 +0100, Chris Wilson wrote: > @@ -1751,6 +1759,12 @@ int i915_gem_fault(struct vm_area_struct *area, struct vm_fault *vmf) > (area->vm_end - area->vm_start) / PAGE_SIZE - > partial.params.partial.offset); > > + /* If the partial covers the entire object, just create a > + * normal VMA. > + */ > + if (chunk_size <= obj->base.size >> PAGE_SHIFT) Surely you meant >= ? > + partial.type = I915_GGTT_VIEW_NORMAL; > + The 'partial' name is now even worse, at least this is close to the call site. Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx