On Tue, Aug 09, 2016 at 07:59:38PM +0100, Chris Wilson wrote:
> On Tue, Aug 09, 2016 at 11:45:11AM -0700, Carlos Santa wrote:
> > No need for HAS_CORE_RING_FREQ as that flag is actually the same as
> > .has_llc. Feedback from V. Syrjala.
> >
> > Signed-off-by: Carlos Santa <carlos.santa@xxxxxxxxx>
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-
> > drivers/gpu/drm/i915/i915_drv.h | 4 ----
> > 2 files changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 9bd4158..01b6735 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -1898,11 +1898,12 @@ static int i915_ring_freq_table(struct seq_file *m, void *unused)
> > struct drm_info_node *node = m->private;
> > struct drm_device *dev = node->minor->dev;
> > struct drm_i915_private *dev_priv = to_i915(dev);
> > + struct intel_device_info *info = mkwrite_device_info(dev_priv);
> > int ret = 0;
> > int gpu_freq, ia_freq;
> > unsigned int max_gpu_freq, min_gpu_freq;
> >
> > - if (!HAS_CORE_RING_FREQ(dev)) {
> > + if (!info->has_llc) {
>
> Why do you need write access?
>
> if (INTEL_INFO(dev_priv)->has_llc)
>
> or even if (HAS_LLC(dev_priv).
indeed better with HAS_() than with write access.
> -Chris
>
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
