On Mon, Aug 15, 2016 at 08:19:49PM +0530, akash.goel@xxxxxxxxx wrote: > +void i915_guc_register(struct drm_i915_private *dev_priv) > +{ > + if (!i915.enable_guc_submission) > + return; The final state of i915.enable_guc_submission is not known at this time. Does it matter if you set up the log even though guc is not used? Would this not be better driver from guc_submission_enable and guc_submission_disable? -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx