On Fri, Aug 12, 2016 at 06:42:30PM +0100, Matthew Auld wrote: > > -#define STD_MI_OPCODE_MASK 0xFF800000 > > -#define STD_3D_OPCODE_MASK 0xFFFF0000 > > -#define STD_2D_OPCODE_MASK 0xFFC00000 > > -#define STD_MFX_OPCODE_MASK 0xFFFF0000 > > +#define STD_MI_OPCODE_SHIFT (32 - 9) > > +#define STD_3D_OPCODE_SHIFT (32 - 16) > > +#define STD_2D_OPCODE_SHIFT (32 - 10) > > +#define STD_MFX_OPCODE_SHIFT (32 - 16) > Why don't we make use of this one in cmd_header_key? What client is it > supposed to map to? It doesn't map to its own CLIENT, it reuses the RC_CLIENT for its commands. (iirc) -Chris -- Chris Wilson, Intel Open Source Technology Centre _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx