Re: [PATCH 33/37] drm/i915: Only record active and pending requests upon a GPU hang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 12, 2016 at 01:39:34PM +0100, Matthew Auld wrote:
> > +static void engine_record_requests(struct intel_engine_cs *engine,
> > +                                  struct drm_i915_gem_request *first,
> > +                                  struct drm_i915_error_engine *ee)
> > +{
> > +       struct drm_i915_gem_request *request;
> > +       int count;
> > +
> > +       count = 0;
> > +       request = first;
> > +       list_for_each_entry_from(request, &engine->request_list, link)
> > +               count += !!request->batch;
> > +
> > +       ee->requests = NULL;
> > +       kcalloc(count, sizeof(*ee->requests),
> > +               GFP_ATOMIC);
> Surely not Chris :)

Crumbs. Missed that even trying to double check after each iteration.
Thanks,
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux