On Thu, 11 Aug 2016 08:26:31 +0200, Ville Syrjälä wrote: > > > --- a/sound/hda/hdac_i915.c > > +++ b/sound/hda/hdac_i915.c > > @@ -201,7 +201,8 @@ static int pin2port(struct hdac_device *codec, hda_nid_t pin_nid) > > * This function sets N/CTS value based on the given sample rate. > > * Returns zero for success, or a negative error code. > > */ > > -int snd_hdac_sync_audio_rate(struct hdac_device *codec, hda_nid_t nid, int rate) > > +int snd_hdac_sync_audio_rate(struct hdac_device *codec, hda_nid_t nid, > > + int pipe, int rate) > > I thought you'd still want to call it 'dev_id' on the hda side, and just > do the dev_id->pipe conversion here next to the pin->port conversion? > Just figured that would be less confusing for people who are just familiar > with hda and not i915. Agreed, it's more consistent to have a pair of the same terms (pipe, port) vs (dev_id, nid). Except for that, the changes in the audio side look trivial, and it's probably better to go through drm tree, so feel free to take my ack: Reviewed-by: Takashi Iwai <tiwai@xxxxxxx> thanks, Takashi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
