On ke, 2016-08-10 at 08:38 +0100, Chris Wilson wrote: > On Wed, Aug 10, 2016 at 10:29:59AM +0300, Joonas Lahtinen wrote: > > > > On su, 2016-08-07 at 15:45 +0100, Chris Wilson wrote: > > > > > > if (obj->pin_display) { > > > - mappable_size += i915_gem_obj_ggtt_size(obj); > > > - ++mappable_count; > > > + pin_size += obj->base.size; > > > + ++pin_count; > > variables names to form pin_display_* > No. > > > > > > > > > + seq_printf(m, "%u mapped objects, %llu bytes\n", > > > + mapped_count, mapped_size); > > > + seq_printf(m, "%u pinned objects, %llu bytes\n", > > "display pinned objects" > Disagree as well. Would be in line with the "i915_gem_pin_display" in sysfs. If not, then keep the previous test condition? Regards, Joonas > -Chris > -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx