On to, 2016-08-04 at 20:52 +0100, Chris Wilson wrote:
> If we try and read or write to an active request, we first must wait
> upon the GPU completing that request. Let's do that without holding the
> mutex (and so allow someone else to access the GPU whilst we wait). Upn
STILL TYPO Upon ---^
> /* Bounds check destination. */
> if (args->offset > obj->base.size ||
> args->size > obj->base.size - args->offset) {
> ret = -EINVAL;
> - goto out;
> + goto err;
> }
>
> - trace_i915_gem_object_pwrite(obj, args->offset, args->size);
> + ret = __unsafe_wait_rendering(obj, to_rps_client(file), false);
> + if (ret)
> + goto err;
>
> + intel_runtime_pm_get(dev_priv);
> +
> + ret = i915_mutex_lock_interruptible(dev);
> + if (ret)
> + goto err_rpm;
> +
> + trace_i915_gem_object_pwrite(obj, args->offset, args->size);
This trace is still moved, maybe add your reasoning to commit message.
With those addressed (and the RPM fix in separate patch);
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
