> -----Original Message----- > From: Ville Syrjälä [mailto:ville.syrjala@xxxxxxxxxxxxxxx] > Sent: Thursday, August 4, 2016 4:54 PM > To: libin.yang@xxxxxxxxxxxxxxx > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; jani.nikula@xxxxxxxxxxxxxxx; Vetter, Daniel > <daniel.vetter@xxxxxxxxx>; tiwai@xxxxxxx; Yang, Libin <libin.yang@xxxxxxxxx> > Subject: Re: [PATCH v3 2/3] drm/i915: set proper N/MCTS on more platforms > > On Thu, Aug 04, 2016 at 03:58:03PM +0800, libin.yang@xxxxxxxxxxxxxxx wrote: > > From: Libin Yang <libin.yang@xxxxxxxxxxxxxxx> > > > > This patch applies setting proper N/M, N/CTS on more platforms. > > > > Signed-off-by: Libin Yang <libin.yang@xxxxxxxxxxxxxxx> > > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Not that I particularly like this special casing of platforms. We should really try > to unify this across the board, and I thought we already agreed that that was > going to happen? Yes, and based on the spec, even it is not supporting 4K resolution, the n/mcts should also be OK. It is for clock, not for resolution. So I agree to apply the patches to other platforms. Regards, Libin > > > --- > > drivers/gpu/drm/i915/intel_audio.c | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_audio.c > > b/drivers/gpu/drm/i915/intel_audio.c > > index 04e7358..7aa0203 100644 > > --- a/drivers/gpu/drm/i915/intel_audio.c > > +++ b/drivers/gpu/drm/i915/intel_audio.c > > @@ -732,11 +732,7 @@ static int > i915_audio_component_sync_audio_rate(struct device *dev, > > int n; > > int err = 0; > > > > - /* HSW, BDW, SKL, KBL need this fix */ > > - if (!IS_SKYLAKE(dev_priv) && > > - !IS_KABYLAKE(dev_priv) && > > - !IS_BROADWELL(dev_priv) && > > - !IS_HASWELL(dev_priv)) > > + if (!HAS_DDI(dev_priv)) > > return 0; > > > > mutex_lock(&dev_priv->av_mutex); > > -- > > 1.9.1 > > -- > Ville Syrjälä > Intel OTC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
