On to, 2016-08-04 at 08:30 +0100, Chris Wilson wrote: > On Thu, Aug 04, 2016 at 10:25:42AM +0300, Joonas Lahtinen wrote: > > > > On ma, 2016-08-01 at 19:22 +0100, Chris Wilson wrote: > > > > > > If we make the observation that mmap-offsets are only released when we > > > free an object, we can then deduce that the shrinker only creates free > > > space in the mmap arena indirectly by flushing the request list and > > > freeing expired objects. If we combine this with the lockless > > > vma-manager and lockless idling, we can avoid taking our big struct_mutex > > > until we need to actually free the requests. > > > > > > One side-effect is that we defer the madvise checking until we need the > > > pages (i.e. the fault handler). This brings us into line with the other > > > delayed checks (and madvise in general). > > > > > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > Don't necessarily agree with all the "== 0", because it's in the > > minority but; > How about if I take this opportunity to start a new life using > > int err; > if (!err) ... "int ret;" is quite de facto and if (!ret) too; $ git grep '!ret\b' | wc -l 3826 $ git grep 'ret == 0\b' | wc -l 1869 $ git grep '!err\b' | wc -l 2064 So I'm inclined towards ret and !ret... Regards, Joonas > > ? > -Chris > -- Joonas Lahtinen Open Source Technology Center Intel Corporation _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
