Re: [PATCH v2] i915: fix build error with -Werror

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 04, 2016 at 11:30:06AM -0400, Jeff Mahoney wrote:
> This fixes the following build error with -Werror and gcc 6.1:
> 
> drivers/gpu/drm/i915/i915_debugfs.c:2103:6: error: suggest explicit braces to avoid ambiguous 'else' [-Werror=parentheses]
> 
> Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx>

This doesn't apply on -next any more ... Is this still an issue on latest
kernels?
-Daniel
> ---
>  drivers/gpu/drm/i915/i915_debugfs.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2100,9 +2100,10 @@ static int i915_dump_lrc(struct seq_file
>  		return ret;
>  
>  	list_for_each_entry(ctx, &dev_priv->context_list, link)
> -		if (ctx != dev_priv->kernel_context)
> +		if (ctx != dev_priv->kernel_context) {
>  			for_each_engine(engine, dev_priv)
>  				i915_dump_lrc_obj(m, ctx, engine);
> +		}
>  
>  	mutex_unlock(&dev->struct_mutex);
>  
> 
> 
> -- 
> Jeff Mahoney
> SUSE Labs
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux