On Thu, Jul 14, 2016 at 10:25:39AM +0100, Tvrtko Ursulin wrote:
>
> On 13/07/16 17:04, Chris Wilson wrote:
> >On Wed, Jul 13, 2016 at 04:03:40PM +0100, Tvrtko Ursulin wrote:
> >>+ /*
> >>+ * Catch failures to update intel_engines table when the new engines
> >>+ * are added to the driver by a warning and disabling the forgotten
> >>+ * engines.
> >>+ */
> >>+ if (WARN_ON(mask != INTEL_INFO(dev_priv)->ring_mask)) {
> >>+ struct intel_device_info *info =
> >>+ (struct intel_device_info *)&dev_priv->info;
> >
> >I snuck in mkwrite_device_info(), so
> >
> >if (WARN_ON(mask != INTEL_INFO(dev_priv)->ring_mask))
> > mkwrite_device_info(dev_priv)->ring_mask = mask;
>
> This part is just code movement, the block you quote exists before
> this series even!
>
> Follow up patch to this series would be easiest then, or a solitary
> precursor if you insist. Dangers of code movement with edits huh?
> (94b4f3ba483ace6dd4a3f881e19cc18bdbafa6ef)
I was also on a checkpatch witchhunt.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
