On Wed, Dec 07, 2011 at 12:29:20PM -0800, Jesse Barnes wrote: > I think the core support is ready now, but I'd like feedback on the > color key ioctl. It would be good to have a way to disable it at > runtime (w/o color keying enabled, the sprite will always sit on top of > the primary), and potentially add alpha support at some point. > > Would 0 as the color key work well enough as a "disable" flag? Or > should I add a separate field to the ioctl? Anyone have a preference? 0 is black and I can image a legit color key with "black bars". Any other value makes the interface kinda ad-hoc. So a separate field preferred. -Daniel -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48