Re: [PATCH] drm/i915: intel_dp_check_link_status should only return status of link

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.7-rc5 next-20160701]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Manasi-Navare/drm-i915-intel_dp_check_link_status-should-only-return-status-of-link/20160702-124153
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-rhel (attached as .config)
compiler: gcc-4.9 (Debian 4.9.3-14) 4.9.3
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/i915/intel_dp.c: In function 'intel_dp_check_link_status':
>> drivers/gpu/drm/i915/intel_dp.c:3872:24: warning: unused variable 'intel_encoder' [-Wunused-variable]
     struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
                           ^

vim +/intel_encoder +3872 drivers/gpu/drm/i915/intel_dp.c

0e32b39c Dave Airlie           2014-05-02  3856  			return ret;
0e32b39c Dave Airlie           2014-05-02  3857  		} else {
0e32b39c Dave Airlie           2014-05-02  3858  			struct intel_digital_port *intel_dig_port = dp_to_dig_port(intel_dp);
0e32b39c Dave Airlie           2014-05-02  3859  			DRM_DEBUG_KMS("failed to get ESI - device may have failed\n");
0e32b39c Dave Airlie           2014-05-02  3860  			intel_dp->is_mst = false;
0e32b39c Dave Airlie           2014-05-02  3861  			drm_dp_mst_topology_mgr_set_mst(&intel_dp->mst_mgr, intel_dp->is_mst);
0e32b39c Dave Airlie           2014-05-02  3862  			/* send a hotplug event */
0e32b39c Dave Airlie           2014-05-02  3863  			drm_kms_helper_hotplug_event(intel_dig_port->base.base.dev);
0e32b39c Dave Airlie           2014-05-02  3864  		}
0e32b39c Dave Airlie           2014-05-02  3865  	}
0e32b39c Dave Airlie           2014-05-02  3866  	return -EINVAL;
0e32b39c Dave Airlie           2014-05-02  3867  }
0e32b39c Dave Airlie           2014-05-02  3868  
84fa171b Manasi Navare         2016-07-01  3869  static bool
5c9114d0 Shubhangi Shrivastava 2016-03-30  3870  intel_dp_check_link_status(struct intel_dp *intel_dp)
5c9114d0 Shubhangi Shrivastava 2016-03-30  3871  {
5c9114d0 Shubhangi Shrivastava 2016-03-30 @3872  	struct intel_encoder *intel_encoder = &dp_to_dig_port(intel_dp)->base;
5c9114d0 Shubhangi Shrivastava 2016-03-30  3873  	struct drm_device *dev = intel_dp_to_dev(intel_dp);
5c9114d0 Shubhangi Shrivastava 2016-03-30  3874  	u8 link_status[DP_LINK_STATUS_SIZE];
5c9114d0 Shubhangi Shrivastava 2016-03-30  3875  
5c9114d0 Shubhangi Shrivastava 2016-03-30  3876  	WARN_ON(!drm_modeset_is_locked(&dev->mode_config.connection_mutex));
5c9114d0 Shubhangi Shrivastava 2016-03-30  3877  
5c9114d0 Shubhangi Shrivastava 2016-03-30  3878  	if (!intel_dp_get_link_status(intel_dp, link_status)) {
84fa171b Manasi Navare         2016-07-01  3879  		DRM_DEBUG_KMS("Failed to get link status\n");
84fa171b Manasi Navare         2016-07-01  3880  		return false;

:::::: The code at line 3872 was first introduced by commit
:::::: 5c9114d0ced2f16d1bfeda650b4acf95159f4759 drm/i915: Reorganizing intel_dp_check_link_status

:::::: TO: Shubhangi Shrivastava <shubhangi.shrivastava@xxxxxxxxx>
:::::: CC: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@xxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]
  Powered by Linux