On Tue, 13 Mar 2012, Bron Gondwana wrote: > On Tue, Mar 13, 2012 at 10:31:08AM +0200, Leena Heino wrote: > > I think making fulldirhash to use 64bit by default is a right thing > > to do. But if we want a really fast fix then maybe the fulldirhash > > 64bit change should be backed out. > > Personally I think throwing fulldirhash out with the trash is the > right thing to do. We use directory hashing at FM, though I'm > tempted to think it's no longer required what with ext3's 32k > folder limit gone away now. > > I can't see why a 32 bit hash isn't big enough though - it's no > less random, and it's not expensive to calculate. > > > In order to make it really work in both pure or mixed 32bit and > > 64bit environments the fulldirhash code in cyrus should look for the > > data in both places. The tools/rehash script does that already. > > I think looking multiple places is the pragmatic fix. I'd rather it become pluggable, and you could just tell it to use basic, full32 or full64 hash modes. No weird IO penalties and decreased performance that way. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh ---- Cyrus Home Page: http://www.cyrusimap.org/ List Archives/Info: http://lists.andrew.cmu.edu/pipermail/info-cyrus/
