On Fri, 19 Jun 2009 06:47 +0200, "Gabor Gombas" <gombasg@xxxxxxxxx> wrote:
> On Fri, Jun 19, 2009 at 10:09:16AM +1000, Bron Gondwana wrote:
>
> > @@ -192,6 +192,18 @@ struct db_list {
> > static time_t global_recovery = 0;
> > static struct db_list *open_db = NULL;
> >
> > +#define BIT32_MAX 4294967295U
> > +
> > +#if UINT_MAX == BIT32_MAX
> > +typedef unsigned int bit32;
> > +#elif ULONG_MAX == BIT32_MAX
> > +typedef unsigned long bit32;
> > +#elif USHRT_MAX == BIT32_MAX
> > +typedef unsigned short bit32;
> > +#else
> > +#error dont know what to use for bit32
> > +#endif
> > +
>
> If you're touching this code, why not use standard stdint.h types like
> uint32_t here?
Yeah, I was just thinking that actually. Mostly because, well - that's what's already there!
I'll do a stdint rewrite of it all some time soon :)
Bron.
--
Bron Gondwana
brong@xxxxxxxxxxx
----
Cyrus Home Page: http://cyrusimap.web.cmu.edu/
Cyrus Wiki/FAQ: http://cyrusimap.web.cmu.edu/twiki
List Archives/Info: http://asg.web.cmu.edu/cyrus/mailing-list.html
