On Wed, Apr 02, 2008 at 07:46:33AM -0400, Ken Murchison wrote: > Bron Gondwana wrote: >> On Wed, Apr 02, 2008 at 07:19:07AM -0400, Ken Murchison wrote: >>> Bron Gondwana wrote: >>>> On Wed, Apr 02, 2008 at 09:51:50PM +1100, Bron Gondwana wrote: >>>>> On Wed, Apr 02, 2008 at 11:28:07AM +1030, Stephen Carr wrote: >>>>>> I get the following type of error (see below) during replication that >>>>>> appeared after upgrading from 2.3.8 to 2.3.11. >>>>> BAH - upload_messages_from() is broken. >>>>> >>>>> Will reply shortly with a patch, >>>> Ken - CCing you on this one since you'll want this for CVS. >>>> I have compile tested this - haven't rolled it out anywhere, >>>> but it's pretty trivial. >>> I understand the missing check for max_count's value, but is there a >>> reason why you're not checking that its negative? >> unsigned > > Ah, right. Since config_getint() returns signed, we should probably make > max_count signed Sounds reasonable - then I'm happy with <= 0 :) Bron. ---- Cyrus Home Page: http://cyrusimap.web.cmu.edu/ Cyrus Wiki/FAQ: http://cyrusimap.web.cmu.edu/twiki List Archives/Info: http://asg.web.cmu.edu/cyrus/mailing-list.html
