Bron Gondwana wrote: > On Wed, 21 Nov 2007 07:40:21 +0100 (CET), "Simon Matter" <simon.matter@xxxxxxxxx> said: > >> Hi Bron, >> >> Did you consider this one >> http://bugzilla.andrew.cmu.edu/show_bug.cgi?id=3006 in the patch above? >> From a quick look it seems both patches conflict, is #3006 obsolete now? > > You're right, they probably do conflict and Ken has applied 3006. I should > have checked on that. Hmm... > > Actually, my patch doesn't even fix #3006. It does sort of suck to be working > from a stable past point rather than the latest CVS actually when I do these > patches - though it's nice from a stability point of view. > > OK - Ken, would you like me to re-build this patch on top of current CVS, or > would you like to do it yourself? My patch has the replication bugfixes which > are still worth doing, but Simon's logic is actually correct for the test > while mine isn't (though I renamed the function he's using...) If you have the time. I'm off banging on other things at the moment. -- Kenneth Murchison Systems Programmer Project Cyrus Developer/Maintainer Carnegie Mellon University ---- Cyrus Home Page: http://cyrusimap.web.cmu.edu/ Cyrus Wiki/FAQ: http://cyrusimap.web.cmu.edu/twiki List Archives/Info: http://asg.web.cmu.edu/cyrus/mailing-list.html