Reviewer: Cheng Li Review result: Has Nits I am not an expert of IGP flexalgo and this is my first official review. Though I understand what is the Flexalgo and how it can be used, as a routing area engineer. As a new reader of this document, the comments may be more helpful to reflect the true feeling of most readers. But I may make some mistakes, so some comments below are clarification questions. 1. Abstract: [Cheng] Seems too short and simple, recommend to add more text to explain clearer. 2. Introduction, [Cheng] Also, too short. Suggest to add more text to describe what is flexalgo, motivation of why we need this extension. Some text similar to the introduction section in RFC9350 is ok. 3. use case example 3.1 "The Flexible Algorithm definition can specify 'colors' that are used by the operator to include or exclude links during the Flex-Algorithm path computation." [Cheng]suggest to have definition of "color" in term. or, a reference also helps. 3.2 "These link 'colors' are checked in the forwarding direction of the SPF computation - e.g. in the direction from the parent to the child." [Cheng]I can understand the meaning. But what is 'checked' in details? may be good to have some specific words to describe the action? from the parent to the child, these terms come from graph/tree/SPF. No sure if we can find better way to describe the direction. It looks normal to use 'check' in Flex-algo RFCs, like RFC9350 :) 3.3 "the input errors can only be detected at node B." [Cheng] I may ask, why the input errors can ONLY be detected at node B? as a reader who is new to this area(Flexalgo in IGP). better to have some explaination? 3.4 "An operator may measure the rate of such input errors and set certain 'color' on a link locally on node B when the input error rate crosses a certain threshold." [Cheng] Sorry I do not understand this fully. Clarification question: what system you are talking about when you say measure the rate of such input errors? It seems that we have a system to input something. Based on the results, the system set certain 'color' on a link? what input errors will replect on a 'color'? what this color means? Section 4. [Cheng] The name of the TLV is a little bit long, even when it becomes abbreviation, FAERAG, suggest to make it short, or make it readable. 4.1 [Cheng]Type = 10, do we already got the IANA allocation? if not? suggest to use TBA for now. similar comment for all the type value in other TLVs. 4.2 [Cheng] in RFC7308, it looks like the name of the TLV is Extended Administrative Groups, but in this document, it is Extended Administrative Group. Am I missing something? [Cheng]The rules of ignore more than one FAERAG sub-TLV is clear to me, thanks! Section 5 "The format of the IS-IS Flexible Algorithm Include-Any Reverse Admin Group Sub-TLV is identical to the format of the FAERAG Sub-TLV in Section 4." [Cheng] what do you mean identical? even for the EAG part? meaning there will be some EAG info in FAIRAG sub-TLV? Section 6, [Cheng]Same comments like section 5 Section 7,8,9, similar comments like the IS-IS ones. Section 12 Security Considerations. [Cheng] I like to use simple sentence in security section as well. But reviewers always require me to add more text to explain. LOL. Therefore, I will suggest the authors to add more text to in this section, since the security area reviewers may require to do so as well. -- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
