Hi Joe, > On Jan 21, 2025, at 11:37, Joe Clarke via Datatracker <noreply@xxxxxxxx> wrote: > > Reviewer: Joe Clarke > Review result: Ready > > I have been asked to review this draft on behalf of the OPS Directorate. This > draft defines a YANG module that augments the base OSPF YANG module to add > Segment Routing extensions for both OSPFv2 and OSPFv3. There isn't a lot of > text in here beyond the YANG tree and module itself. From an operational > standpoint (not being an SR expert) I'd have to say it's ready. I agree with > Reshad's YANG Doc review that as an operator I'd appreciate a more > comprehensive example in the appendix. > > I also have one question. In addition to config and state, the base OSPF > module defines statistics for OSPF. What SR statistics (if any) should be > included in these augmentations? Given that this document has been around for 8 years and is needed for other OSPF YANG draft, SR statistics should be added in a separate draft/augmentation. Thanks, Acee > > -- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
