Reviewer: Brian Trammell Review result: Ready with Issues This document has been reviewed as part of the transport area review team's ongoing effort to review key IETF documents. These comments were written primarily for the transport area directors, but are copied to the document's authors and WG to allow them to address any issues raised and also to the IETF discussion list for information. When done at the time of IETF Last Call, the authors should consider this review as part of the last-call comments they receive. Please always CC tsv-art@xxxxxxxx if you reply to or forward this review. This seems like a fairly straightforward extension to BFD that adds the ability to make loopback packet larger in order to check bidirectional forwarding MTU. I have no particular transport concerns with this extension in isolation. I'm not sure about the statement in the security considerations section that "[t]his document does not change the underlying security considerations of the BFD protocol or its encapsulations." Yes, it's not the 90s anymore, but AIUI the concept does involve changing packet sizes across potentially multiple encapsulation layers where there might be lurking assumptions about packet lengths and buffer size, and buffer size misalignments are still an easy place to find vulnerabilities. Would a statement to the effect that implementors of this specification should take care with packet sizes being dynamic where prior to this extension they were not be warranted in the security considerations section? -- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
