Thanks Greg for clarification, please see follow up comment below.
发件人: Greg Mirsky [mailto:gregimirsky@xxxxxxxxx]
发送时间: 2024年10月31日 18:58
收件人: Qin Wu <bill.wu@xxxxxxxxxx>
抄送: ops-dir@xxxxxxxx; draft-ietf-mpls-1stnibble.all@xxxxxxxx; last-call@xxxxxxxx; mpls@xxxxxxxx
主题: Re: Opsdir last call review of draft-ietf-mpls-1stnibble-10
Hi Qin Wu,
thank you for your thorough review and thoughtful comments. Please find my notes below tagged GIM>>.
Regards,
Greg
On Thu, Oct 31, 2024 at 6:14 AM Qin Wu via Datatracker <noreply@xxxxxxxx> wrote:
Reviewer: Qin Wu
Review result: Has Nits
I have reviewed this document as part of the Operational directorate's ongoing
effort to review all IETF documents being processed by the IESG. These
comments were written with the intent of improving the operational aspects of
the IETF drafts. Comments that are not addressed in last call may be included
in AD reviews during the IESG review. Document editors and WG chairs should
treat these comments just like any other last call comments.
This document specifies the new IANA registry for the first Nibble Following a
Label Stack. In addition, this document provide requirements for registering
new values and recommendation for MPLS packet processing. This document is well
written and is on the right track, however, I do have a few comments for
questions and clarifications:
1. Abstract Abstract said: “this memo sets out
some documentation requirements for registering new values. Finally, it
provides some recommendations that make processing MPLS packets easier and more
robust.” Abstract also said: “This document updates RFC 4928 by deprecating the
heuristic method for identifying the type of packet encapsulated in MPLS.” I am
wondering whether deprecating the heuristic method for identifying the type of
packet encapsulated in MPLS is seen as recommendation or requirements, if yes,
is such duplicated?GIM>> The deprecation of the heuristic method is formulated as the requirement in the following in Section 2.1.1.1:
Furthermore, the heuristic of guessing
the type of the embedded packet, as discussed above, SHOULD NOT be
used.
I hope that clarifies the relationship between the deprecation and the requirement.
2. Abstract Some place in the abstract uses the term "This
memo", some place in the place uses the term "this document", the same comment
is applied to the introduction section, suggest to make these terms consistent?
Suggest to use the term "This document".GIM>> These terms, 'memo' and 'document', have been used interchangeably in RFCs. For example, RFC 2223 says, "This memo provides information for the Internet community." I hope you agree to both terms' current use in the draft.
[Qin] Is using ‘memo’and ‘document’interchangeably best practice today? I feel this is old fashion, never used
In the latest RFCs today. You can see only IETF draft boiplate will use memod, e.g.,”status of memo”.
3. Section 1 Introduction said: “ This
memo introduces a requirement and a recommendation. The first builds on Section
2.1.1, and the second deprecates the use of the heuristic in Section 2.1.1.1
and recommends using a dedicated label value for load balancing. ” Abstract
also said: “ this memo sets out some documentation requirements for registering
new values. Finally, it provides some recommendations that make processing MPLS
packets easier and more robust. ” How many requirements and recommendations are
specified by this document, one or many, it looks the abstract is not consist
with Introduction for this. Secondly, where these requirements and
recommendations are documented? Only section 2.1.1 and section 2.1.1.1, or we
have some other sections? My suggestion is to have two clear sections to
document requirements and recommendations separately.GIM>> The document addresses two areas:
- load-balancing
- use of post-stack first nibble
For the former, as noted in "This memo introduces a requirement and a recommendation," the draft formulates one requirement and one recommendation. For the latter, it includes additional requirements. Grouping requirements in one section would mix what is being discussed, which might confuse a reader. I hope we can maintain the document's current organization unchanged.
[Qin] My Concern is as the first reader of this document, the abstract lacks consistency with introduction on how many recommendations and requirements are documented.
e.g., in the introduction, at least you can add some text to say:
OLD TEXT:
“This memo introduces a requirement and a recommendation.”
NEW TEXT:
“This memo firstly introduces a requirement and a recommendation in section xxx.”
OLD TEXT:
“
This document updates [RFC4928] by deprecating the heuristic methodfor identifying the type of packet encapsulated in MPLS.
”
NEW TEXT:
“
This document further updates [RFC4928] by deprecating the heuristic methodfor identifying the type of packet encapsulated in MPLS in section xxx.
”
I also feel it lack clarity to mix rationale with recommendations and requirements, what do you think about this?
4. Section 3.1
Section 3.1 said:
“
The assignment policy for the registry is Standards Action.
“
Can we add reference for standard action, I think it should be RFC8126.GIM>> Agree. I added RFC 8126 as an Informative reference.
[Qin]: Why not normative reference, see example in RFC9184.
-- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
