> On Oct 31, 2024, at 12:19 PM, Benjamin Schwartz via Datatracker <noreply@xxxxxxxx> wrote: > > Reviewer: Benjamin Schwartz > Review result: Ready > > This specification is not highly security-relevant, and it does not have any > content in its Security Considerations. > > In general, allowing file metadata, including size and ownership, to be > desynchronized from the file contents, does carry significant security > implications. For example, understating the size of the file could lead to a > buffer overflow in an incautious client. If these considerations have already > been addressed in another document, I think a specific citation to that text > would be appropriate here. > > Hi Benjamin, Thanks for the review. No, these are not considered concerns in general because of the nature of the filesystem being remote. A client would not assume that a size would remain constant even without these changes. As a client reads a file, it fills its page cache with the contents. If there were more pages than expected, then the cache would either allow more pages to be allocated or it would trim the older entries. I.e., a client does not pre-allocate an exact buffer for a file. Thanks, Tom -- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
