Dear Carl, On Sun, Jul 28, 2024 at 08:37:33AM -0700, Carl Wallace via Datatracker wrote: > Reviewer: Carl Wallace > Review result: Ready > > This draft defines the SendHoldtimer and SendHoldTimer_Expires for the BGP > state machine. The draft is straightforward and well written but I had one > minor nit. In section 3.3, there is a NEW block to be added that begins "If the > SendHoldTimer_Expires (Event 29), the local system:". This seems to be > incomplete. From similar text in 4271, one fix would be to put the word > "occurs" before the comma. Thank you for your review and attention to detail! It appears I copy+pasted this pattern in from RFC 4271's section with "If the HoldTimer_Expires (Event 10), the local system:" :-) I appreciate your suggestion, it's been fixed in the edit-buffer https://github.com/bgp/draft-ietf-idr-bgp-sendholdtimer/commit/948449d93218d7dbfc04f7b9663611a4a2d68c1c Kind regards, Job -- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
