|
Authors,
A few comments/nits.
[Comment 1] module: ietf-rift augment /rt:routing/rt:control-plane-protocols /rt:control-plane-protocol: +--rw rift* [name] ... +--rw instance-label? uint32 {label-switching}?
The base spec does mention that labels can be used to distinguish between RIFT instances, but that's not it's only use. The YANG model has it scoped incorrectly. It should be in the "neighbors" hierarchy so that it's per-adjacency and not at the instance level, the name should be changed as appropriate.
The existing per-prefix label indication is fine as is. [Comment 2] leaf tide-generation-interval { type rt-types:timer-value-seconds16; units seconds; default "5"; description "The TIDE generation interval."; } The base spec no longer specifies the default TIDE generation interval, you can remove it.
Other than that, just nits
[nit 1] The current "instance-label" description should be more generic.
I'd suggest removing "This value can be used to distinguish among multiple RIFT instances."
[nit 2] The "loopback" description seems to be referring to the wrong section in the base spec. Not sure which one you intended.
Perhaps double check any other instances of this as lots of things moved around in the last couple of iterations of the base spec.
[nit 3] Descriptions in the “state” leaf seem to be incorrect, perhaps a copy and paste error?
[nit 4] The PoD description points out level 0 and level 1 specifically. Level 0 indicates leaf, which is fine, but the next level up could be anything above 0 and less than 24.
I'd suggest something like "normally only leaf nodes (level 0) and their immediate northbound neighbors" Thanks Jordan
|
-- last-call mailing list -- last-call@xxxxxxxx To unsubscribe send an email to last-call-leave@xxxxxxxx
