Sgtm
On Tue, Apr 16, 2024, 23:05 <mohamed.boucadair@xxxxxxxxxx> wrote:
Hi Martin,
Thank you for the review.
Good point about the ranges. Updated the text as you can see at: https://github.com/boucadair/simple-ipfix-fixes/pull/10/files.
I double checked the registry and found that same issue should be fixed for other IEs: https://github.com/boucadair/simple-ipfix-fixes/pull/11/files. Please note that unlike the other entries, I'm not listing DCCP for collectorTransportPort/exporterTransportPort because of rfc7011#section-10.
Added a note for the IANA so that consistent referencing is used.
Cheers,
Med
> -----Message d'origine-----
> De : Martin Duke via Datatracker <noreply@xxxxxxxx>
> Envoyé : mercredi 17 avril 2024 00:55
> À : tsv-art@xxxxxxxx
> Cc : draft-ietf-opsawg-ipfix-fixes.all@xxxxxxxx; last-call@xxxxxxxx;
> opsawg@xxxxxxxx
> Objet : Tsvart last call review of draft-ietf-opsawg-ipfix-fixes-07
>
>
> Reviewer: Martin Duke
> Review result: Ready with Nits
>
> This document has been reviewed as part of the transport area review
> team's ongoing effort to review key IETF documents. These comments
> were written primarily for the transport area directors, but are
> copied to the document's authors and WG to allow them to address any
> issues raised and also to the IETF discussion list for information.
>
> When done at the time of IETF Last Call, the authors should consider
> this review as part of the last-call comments they receive. Please
> always CC tsv-art@xxxxxxxx if you reply to or forward this review.
>
> This document does some housekeeping on the IPFIX Information Elements
> registry, to conform to a standard table format and fix other minor
> errors. There are no transport protocol implications.
>
> The reference to the port registry is correct. It might be good for
> PortRangeStart and PortRangeEnd to clarify that the linked registry is
> not just for TCP, but also UDP, SCTP, and DCCP.
>
____________________________________________________________________________________________________________
Ce message et ses pieces jointes peuvent contenir des informations confidentielles ou privilegiees et ne doivent donc
pas etre diffuses, exploites ou copies sans autorisation. Si vous avez recu ce message par erreur, veuillez le signaler
a l'expediteur et le detruire ainsi que les pieces jointes. Les messages electroniques etant susceptibles d'alteration,
Orange decline toute responsabilite si ce message a ete altere, deforme ou falsifie. Merci.
This message and its attachments may contain confidential or privileged information that may be protected by law;
they should not be distributed, used or copied without authorisation.
If you have received this email in error, please notify the sender and delete this message and its attachments.
As emails may be altered, Orange is not liable for messages that have been modified, changed or falsified.
Thank you.
_______________________________________________
Tsv-art mailing list
Tsv-art@xxxxxxxx
https://www.ietf.org/mailman/listinfo/tsv-art
-- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
