Reviewer: Antoine Fressancourt Review result: Ready with Nits I am an assigned INT directorate reviewer for draft-ietf-ccamp-l1csm-yang-25.txt. These comments were written primarily for the benefit of the Internet Area Directors. Document editors and shepherd(s) should treat these comments just like they would treat comments from any other IETF contributors and resolve them along with any other Last Call comments that have been received. For more details on the INT Directorate, see https://datatracker.ietf.org/group/intdir/about/ <https://datatracker.ietf.org/group/intdir/about/>. Based on my review, if I was on the IESG I would ballot this document as YES (or NO OBJECTION). The following are issues I found with this document that SHOULD be corrected before publication: * In the Security considerations in Section 5, the authors give a good description of the possible service disruptions that may occur in case the YANG module is misused voluntarily or not. Besides the possibility of a service malfunction, I would argue that a misuse, or more precisely a targeted attack on the YANG module would allow an attacker to configure the layer 1 connectivity so that it places an eavesdropper for some communications between two specific entities. I am curious about whether the draft authors have considered this risk, if they think it is worth mentioning in the draft, or if this risk is mentioned in other documents and should not make its way in this draft. * While reading the document, I found it odd that RFC 4847 is only given as an informative reference, given that it is one of the most cited document in this draft and that, as a layperson, reading this RFC was necessary for me to get a proper understanding of the current draft's content. I guess this is related to the informative status of RFC 4847, but I think it is really strange. The following are minor issues (typos, misspelling, minor text improvements) with the document: * In section 1.2, I would list the key terms you are using from RFC 4847, RFC 5253 and MEF 63. -- last-call mailing list last-call@xxxxxxxx https://www.ietf.org/mailman/listinfo/last-call
